Add env and env-file flags for action create/update#523
Open
giusdp wants to merge 1 commit intoapache:masterfrom
Open
Add env and env-file flags for action create/update#523giusdp wants to merge 1 commit intoapache:masterfrom
giusdp wants to merge 1 commit intoapache:masterfrom
Conversation
|
Can you explain to me how the environment variables are passed to the action initialization route in the action-proxy? I thought the OpenWhisk-CLI simply sends requests to the OpenWhisk API? And as far as I can tell, the OpenWhisk API does not directly support passing environment variables to actions on initialization. Unless there is an undocumented annotation for it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the PR that adds the Env field to the action struct in client-go apache/openwhisk-client-go#158, this PR adds the
--envand--env-fileflag to wsk action create/update.It follows closely the code for the --params and --annotation flags to add support for passing environment variables during action initialization.
I tried to extend some tests in Go but let me know where I should add more.
I've also updated the client-go dep to the latest commit and run
go mod tidywhich removed many deps.